r.null: added test cases the module #5214
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
raster
petrasovaa
reviewed
Feb 26, 2025
petrasovaa
reviewed
Feb 26, 2025
petrasovaa
reviewed
Feb 26, 2025
petrasovaa
reviewed
Feb 26, 2025
petrasovaa
reviewed
Feb 26, 2025
petrasovaa
reviewed
Feb 26, 2025
petrasovaa
reviewed
Mar 3, 2025
| # Create map1: categories 1, 2, 3 as rows | ||
| cls.runModule( | ||
| "r.mapcalc", | ||
| expression="map_basic = if(row() == 1, 1, if(row() == 2, 2, if(row() == 3, 3, null())))", |
There was a problem hiding this comment.
This could be simplified:
map_basic = row()
petrasovaa
reviewed
Mar 3, 2025
| self.assertModule(module) | ||
|
|
||
| # Validate category mappings using r.category | ||
| category_output = gs.parse_command("r.describe", map="map_basic", format="json") |
There was a problem hiding this comment.
using "1" flag here to just list all the values seems better
petrasovaa
reviewed
Mar 3, 2025
| module = SimpleModule("r.null", map="map2", setnull="1", flags="f") | ||
| self.assertModule(module) | ||
|
|
||
| category_output = gs.parse_command("r.describe", map="map2", format="json") |
There was a problem hiding this comment.
here the range flag may be better for the floating point
petrasovaa
reviewed
Mar 3, 2025
|
|
||
| def test_fill_nulls(self): | ||
| """Verify module fills nulls""" | ||
| module = SimpleModule("r.null", map="map_fill_nulls", null="1") |
There was a problem hiding this comment.
This is not doing much, it would be better if the input had some nulls, no?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces tests for the
r.nullmodule to validate its functionality. The tests cover:Basic Functionality: Verifies that
r.nullcorrectly adds null values in the raster map usingsetnullparameter.Float Maps: Tests the
-fflag for adding null values in the float map.Fill Nulls: Tests
nullparameter to replace null valuesThe tests use temporary regions and custom raster maps.